feat(queue): add event type to log messages in QueueConsumer#707
Open
jekabs-karklins wants to merge 1 commit into
Open
feat(queue): add event type to log messages in QueueConsumer#707jekabs-karklins wants to merge 1 commit into
jekabs-karklins wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves QueueConsumer observability by including the consumed event type in the “Received message on queue” log entry, making it easier to debug message flows across queues.
Changes:
- Extract the first callback argument as
eventTypeinQueueConsumer.start()and include it in the structured log metadata. - Update
QueueConsumerunit tests to pass(eventType, message, properties)and assert the updated log payload andonMessageinvocation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/queue/consumers/QueueConsumer.ts | Adds eventType to the “Received message on queue” log metadata. |
| src/queue/consumers/QueueConsumer.spec.ts | Updates tests to reflect the event-type-first callback signature and new log fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logs should display not only queue name but event type.
Motivation and Context
This would help considerably when debugging
How Has This Been Tested
Updated tests